Repository navigation
fix(cron): stop retrying failed scheduled occurrences - #3934
Open
uiharuayako wants to merge 2 commits into
Open
uiharuayako wants to merge 2 commits into
uiharuayako wants to merge 2 commits into
Conversation
Contributor
Author
|
这个问题会导致上百条的重试记录,希望能够合入修复 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A daily workspace-targeted job could create a new session every five seconds when submission failed after session creation. Failed submissions now finish that occurrence and retain its error: recurring jobs wait for their next scheduled time, and one-shot jobs stop until explicitly run again.
Fixes #3933.
Type and Areas
Type: bug fix.
Areas: portable Agent Runtime scheduled-job state and Rust core cron service.
Motivation / Impact
Verification
cargo test --locked -p openbitfun-agent-runtime --no-default-features --features agent-runtime --test agent_session_contracts scheduled_job_contracts: 13 passed.cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,scheduled-jobs,git --lib service::cron::service::tests: 18 passed.New failure regressions were reproduced against the pre-fix code. Coverage includes daily scheduling, one-shot/manual execution, missing sessions, legacy-state restoration, and serialization round trips.
pnpm run fmt:rs,git diff --check origin/main...HEAD, andnode scripts/check-git-object-sizes.mjs --base origin/main --head HEADpassed.pnpm run check:core-boundaries: passed.pnpm run check:core-boundaries:test: 158 passed. The source gate and its self-test require the failed-trigger consumption, next-schedule, and explicit manual-run regressions.Reviewer Notes
Persisted job/state shapes remain unchanged. Startup reconciliation preserves failure history and the next scheduled time.
AI-assisted with Codex. Testing level: focused unit and contract tests. GUI, live provider, remote workspace, Remote Control, Peer Device, and Detached Dispatch end-to-end scenarios were not exercised.
Checklist